Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results on NeRF 360 Dataset #52

Open
ch-ho00 opened this issue Jan 30, 2023 · 4 comments
Open

Results on NeRF 360 Dataset #52

ch-ho00 opened this issue Jan 30, 2023 · 4 comments

Comments

@ch-ho00
Copy link

ch-ho00 commented Jan 30, 2023

Hi. Thank you for open-sourcing the great work!
I want to know how the results on the project pages are implemented.
Because based on the code, LLFF and NeRF 360 dataset uses one view for test (closest to the average pose) and the rest for training.
I was wondering if that is the case for reported DCVGO results.

Thank you in advance

@sjtuytc
Copy link

sjtuytc commented Feb 22, 2023

What do you mean by one view for the test? I think the dataset split of DVGO follows previous works.

@ch-ho00
Copy link
Author

ch-ho00 commented Feb 22, 2023

My understanding is that mip-nerf360 dataset is set to be a dataset type LLFF based on the below line.
https://github.com/sunset1995/DirectVoxGO/blob/main/configs/nerf_unbounded/nerf_unbounded_default.py#L6

And LLFF datasets only leave on view out for validation/test.
https://github.com/sunset1995/DirectVoxGO/blob/main/lib/load_llff.py#L416

@sjtuytc
Copy link

sjtuytc commented Feb 22, 2023

I'll see this later. But since dvgo is already a good baseline, We can just follow it.

@ch-ho00
Copy link
Author

ch-ho00 commented Feb 22, 2023

I'm not saying that DVGO is not a good baseline. I'm just making sure the reported result is based on only one view because the dataset contains a 360 degree scene so testing only on one view seems odd for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants