Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only version 1 certificates? #14

Open
nulman opened this issue Aug 31, 2021 · 2 comments
Open

only version 1 certificates? #14

nulman opened this issue Aug 31, 2021 · 2 comments

Comments

@nulman
Copy link

nulman commented Aug 31, 2021

All certificates generate as "Version: 1 (0x0)"

Looking at the code, I see that cert.set_version is not used anywhere so it defaults to 0 (version 1).
I think perhaps this should also be either inferred from the read certs, passed as a config option or at least default to cert.set_version(2) (version 3) anywhere after this line

cert = crypto.X509()

@tomato42
Copy link

Doesn't the code default to version 3 (0x2) when the extensions are present?

@nulman
Copy link
Author

nulman commented Aug 31, 2021

It does not appear to be so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants