{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2319498,"defaultBranch":"master","name":"subsurface","ownerLogin":"subsurface","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-09-03T15:27:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3876063?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715724958.0","currentOid":""},"activityList":{"items":[{"before":"c3d807802deffa8233edd5e32da7e0d63c43a4a2","after":"245f8002a8466b5270e1d8865cf0b1096cff7390","ref":"refs/heads/master","pushedAt":"2024-05-19T21:56:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mikeller","name":"Michael Keller","path":"/mikeller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4742747?s=80&v=4"},"commit":{"message":"CICD: Remove Workflow to Build ubuntu 14.04 Docker Image.\n\nRemove the workflow for building an ubuntu 14.04 Docker image. This is\nno longer needed since the AppImage is now built on 16.04.\n\nSigned-off-by: Michael Keller ","shortMessageHtmlLink":"CICD: Remove Workflow to Build ubuntu 14.04 Docker Image."}},{"before":"a66bdb1bf5b8f69e4262f1d331ff211b8228caa1","after":"c3d807802deffa8233edd5e32da7e0d63c43a4a2","ref":"refs/heads/master","pushedAt":"2024-05-18T12:07:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"Desktop: Fix Finding Reported by Coverity.\n\nSigned-off-by: Michael Keller ","shortMessageHtmlLink":"Desktop: Fix Finding Reported by Coverity."}},{"before":"b579342639cf02f5d0e561b8dd38a2bcb8d0ea05","after":"a66bdb1bf5b8f69e4262f1d331ff211b8228caa1","ref":"refs/heads/master","pushedAt":"2024-05-17T04:44:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mikeller","name":"Michael Keller","path":"/mikeller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4742747?s=80&v=4"},"commit":{"message":"Planner: Improve Exit Warning.\n\nImprove the warning shown to the user when closing the application wile\nin the planner. We now allow the user to directly discard the planned\ndive, save it into the dive log, or cancel the operation altogether.\nIf they save into the dive log, or if they modified the dive log before\nstarting the planner, a second warning about the unsaved dive log\nchanges will be shown.\n\nSigned-off-by: Michael Keller ","shortMessageHtmlLink":"Planner: Improve Exit Warning."}},{"before":"888704e8168a5780483ec5c20955803474e9b133","after":"b579342639cf02f5d0e561b8dd38a2bcb8d0ea05","ref":"refs/heads/master","pushedAt":"2024-05-16T14:39:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"Cleanup: Remove 'context' Reference from Logging Defines.\n\nRemove the reference to `context` from the defines used for logging, as\nthis is not used.\n\nSigned-off-by: Michael Keller ","shortMessageHtmlLink":"Cleanup: Remove 'context' Reference from Logging Defines."}},{"before":"6880937838acad81a5c24d62fed71c5c7fad1d54","after":"888704e8168a5780483ec5c20955803474e9b133","ref":"refs/heads/master","pushedAt":"2024-05-15T01:29:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mikeller","name":"Michael Keller","path":"/mikeller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4742747?s=80&v=4"},"commit":{"message":"CICD: Have the Artifact Comment Workflow Suppress 'No Artifacts' Errors.\n\nSuppress errors in the 'Add Artifact Comment' workflow if there are no\nartifacts produced by the pull request workflow - this gets rid of\nfollow-on error messages when a pull request workflow encounters a build\nerror.\n\nSigned-off-by: Michael Keller ","shortMessageHtmlLink":"CICD: Have the Artifact Comment Workflow Suppress 'No Artifacts' Errors."}},{"before":null,"after":"4a156d63cd80bc49d327e1641fc3e1683091e836","ref":"refs/heads/qt6translationtooling","pushedAt":"2024-05-14T22:15:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dirkhh","name":"Dirk Hohndel","path":"/dirkhh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/237471?s=80&v=4"},"commit":{"message":"update translation tooling to work with Qt6\n\nSigned-off-by: Dirk Hohndel ","shortMessageHtmlLink":"update translation tooling to work with Qt6"}},{"before":"b60d2318d68518ee2b44f9cd2a90626bc47eb903","after":"4c8d1c9f0bf6d42786fa8400d872c845a0304df6","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T21:33:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: remove typedefs in pref.h\n\nSome compilers whine when using typedefs with non-C structs with\ndefault initializers. Not yet the case here, but in the future\nprobably will. So remove them now. No point in C++ anyway.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: remove typedefs in pref.h"}},{"before":"9b80393c978e3913f2cdf22151162f23c66b6005","after":null,"ref":"refs/heads/bstoeger-report-info","pushedAt":"2024-05-14T21:19:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mikeller","name":"Michael Keller","path":"/mikeller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4742747?s=80&v=4"}},{"before":"d018b72dab6753f06925f1a4dcecebce3ed4d710","after":"6880937838acad81a5c24d62fed71c5c7fad1d54","ref":"refs/heads/master","pushedAt":"2024-05-14T21:19:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mikeller","name":"Michael Keller","path":"/mikeller","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4742747?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INFO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"d58ba29f00387a375c336a6db42647c57fc63ce8","after":"b60d2318d68518ee2b44f9cd2a90626bc47eb903","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T21:08:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: remove typedefs in pref.h\n\nSome compilers whine when using typedefs with non-C structs with\ndefault initializers. Not yet the case here, but in the future\nprobably will. So remove them now. No point in C++ anyway.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: remove typedefs in pref.h"}},{"before":"adf14a82b2073b7c6a52c14c0207c3878e1860eb","after":"d58ba29f00387a375c336a6db42647c57fc63ce8","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T20:47:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"divelog: turn owning-pointers into unique_ptr<>s\n\nSince everything is C++ now, we can use unique_ptr<>s. This makes\nthe code significantly shorter, because we can now use the default\nmove constructor and assignment operators.\n\nThis has a semantic change when std::move()-ing the divelog:\nnow not the contents of the tables are moved, but the pointers.\nThat is, the moved-from object now has no more tables and\nmust not be used anymore. This made it necessary to replace\nstd::move()s by std::swap()s. In that regard, the old code was\nin principle broken: it used moved-from objects, which may work\nbut usually doesn't.\n\nThis commit adds a myriad of .get() function calls where the code\nexpects a C-style pointer. The plan is to remove virtually all of\nthem, when we move free-standing functions into the class it acts\non. Or, replace C-style pointers by references where we don't support\nNULL.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"divelog: turn owning-pointers into unique_ptr<>s"}},{"before":"e9c095246cedb67a19e1a1af77881fceafb7e4ad","after":"adf14a82b2073b7c6a52c14c0207c3878e1860eb","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T20:46:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"x\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"x"}},{"before":"7526dfbe39fc33ec718185d68a434fe87bb8e673","after":"e9c095246cedb67a19e1a1af77881fceafb7e4ad","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T20:15:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INDO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"a1fffba514009b96744bf7c022e8a428c10ca141","after":"9b80393c978e3913f2cdf22151162f23c66b6005","ref":"refs/heads/bstoeger-report-info","pushedAt":"2024-05-14T19:54:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INFO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"89c4061b5895f176e68b924a5819a7bfe105a92c","after":"7526dfbe39fc33ec718185d68a434fe87bb8e673","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T19:41:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INDO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"0873d43af7ab37d643a8c323b7a5364824645f79","after":"89c4061b5895f176e68b924a5819a7bfe105a92c","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T19:34:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"fix ftdi\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"fix ftdi"}},{"before":"8f99cbc54ee5e0c921c62d86c59dbaf319923b99","after":"a1fffba514009b96744bf7c022e8a428c10ca141","ref":"refs/heads/bstoeger-report-info","pushedAt":"2024-05-14T19:22:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INFO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":null,"after":"8f99cbc54ee5e0c921c62d86c59dbaf319923b99","ref":"refs/heads/bstoeger-report-info","pushedAt":"2024-05-14T19:20:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INDO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"fa442db90c03256d93a9cc94fffec809cdbaf252","after":"0873d43af7ab37d643a8c323b7a5364824645f79","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T19:19:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp\n\nError introduced in da7ea17b66: the INDO() and ERROR() macros\npass stdout instead of the format string as first parameter\nto report_error(). Ooooops. How did this ever pass the\ncompile tests!?\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"core: fix INFO() and ERROR() macros in core/serial_ftdi.cpp"}},{"before":"b1fd88aa3dde75fb282c109584cd0c9730f7fc7e","after":"fa442db90c03256d93a9cc94fffec809cdbaf252","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T19:12:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"89540aaf8890d09a5658b2f0c1209b2b3ecb2928","after":"b1fd88aa3dde75fb282c109584cd0c9730f7fc7e","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T18:58:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"dummy test commit\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"dummy test commit"}},{"before":"0d6cf876158d36e0bf888ed89181c77c7eb4597c","after":"89540aaf8890d09a5658b2f0c1209b2b3ecb2928","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T18:47:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"dummy test commit\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"dummy test commit"}},{"before":"24225330eded2293bd85f83d9c443378f4cba612","after":"0d6cf876158d36e0bf888ed89181c77c7eb4597c","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T18:33:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"4fe32d1b356c321f1b38fc17ac66b94d18bfd012","after":"24225330eded2293bd85f83d9c443378f4cba612","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T18:16:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"c3fb4cf59c4408a81921c1f6cd6fe672adcda338","after":"4fe32d1b356c321f1b38fc17ac66b94d18bfd012","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T17:32:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"8fedba6614d986d9520f8233af29ed20a2a70139","after":"c3fb4cf59c4408a81921c1f6cd6fe672adcda338","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T16:35:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"325c1e5d055b078422a76cb4fd396a4693fa4d26","after":"8fedba6614d986d9520f8233af29ed20a2a70139","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T15:35:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"66d1ba35ef06e2ad08ee5042f2d7eda7cedb5373","after":"325c1e5d055b078422a76cb4fd396a4693fa4d26","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T15:28:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"9984c976b3b6e23e63dc3acf9715204d03307af0","after":"66d1ba35ef06e2ad08ee5042f2d7eda7cedb5373","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T14:57:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}},{"before":"c401bfc5bf91f6a89295ec152733c0e81698a5a8","after":"9984c976b3b6e23e63dc3acf9715204d03307af0","ref":"refs/heads/bstoeger-strtod","pushedAt":"2024-05-14T14:43:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"bstoeger","name":null,"path":"/bstoeger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32835590?s=80&v=4"},"commit":{"message":"cleanup: move helper function from qthelper.cpp to save-html.cpp\n\nThe point of qthelper.cpp was that C-code couldn't access Qt\nconvenience functions directly.\n\nNow that everything is C++ these helpers can be moved back,\nat least if there is only one caller.\n\nDo this for the picture-copy code in save-html.cpp. This\nfixes a memory leak (a string was copied, but never freed).\nUse std::fileformat instead of the Qt version.\n\nSigned-off-by: Berthold Stoeger ","shortMessageHtmlLink":"cleanup: move helper function from qthelper.cpp to save-html.cpp"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETkNs4AA","startCursor":null,"endCursor":null}},"title":"Activity ยท subsurface/subsurface"}