Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long model names cause too long job names #256

Open
samos123 opened this issue Oct 15, 2023 · 0 comments
Open

Long model names cause too long job names #256

samos123 opened this issue Oct 15, 2023 · 0 comments

Comments

@samos123
Copy link
Contributor

Steps to reproduce:

  1. Create a model with following name: wgqlg-withretrieval-schemasplit-train-80-mistral-instruct

Current result:
No job gets created and following log is observed:

2023-10-15T03:59:28Z    ERROR   Reconciler error        {"controller": "model", "controllerGroup": "substratus.ai", "controller
Kind": "Model", "Model": {"name":"wgqlg-withretrieval-schemasplit-train-80-mistral-instruct","namespace":"default"}, "namespace
": "default", "name": "wgqlg-withretrieval-schemasplit-train-80-mistral-instruct", "reconcileID": "fbf39151-3ddb-400f-8704-401b
3d605bb5", "error": "creating Job: Job.batch \"wgqlg-withretrieval-schemasplit-train-80-mistral-instruct-modeller\" is invalid:
 [metadata.labels: Invalid value: \"wgqlg-withretrieval-schemasplit-train-80-mistral-instruct-modeller\": must be no more than 63 characters, spec.template.labels: Invalid value: \"wgqlg-withretrieval-schemasplit-train-80-mistral-instruct-modeller\": must be no more than 63 characters]"}                                                                                             
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                  /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:324                           sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265                           sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2                                                     /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226   
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant