Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Reconciler Errors while waiting on upload #194

Open
nstogner opened this issue Aug 17, 2023 · 0 comments
Open

Build Reconciler Errors while waiting on upload #194

nstogner opened this issue Aug 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nstogner
Copy link
Contributor

nstogner commented Aug 17, 2023

[manager] 2023-08-16T23:43:25Z  ERROR   Reconciler error        {"controller": "notebook", "controllerGroup": "substratus.ai", "controllerKind": "Notebook", "Notebook": {"name":"example","namespace":"default"}, "namespace": "default", "name": "example", "reconcileID": "98e13661-b56f-4b99-bdb4-16153b0b1d29", "error": "getting storage object md5: calling the sci service to GetObjectMd5: rpc error: code = Unknown desc = storage: object doesn't exist"}
[manager] sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
[manager]       /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:324
[manager] sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
[manager]       /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:265
[manager] sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
[manager]       /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/internal/controller/controller.go:226

How to reproduce:

With controller stopped:

kubectl notebook -d .

Wait for it to attempt to upload... Ctrl-C

Start controller.

Proposed Solution:

SCI could return a Not Found gRPC status code and the controller could check for this error and avoid returning an error in this case (which would avoid sending the controller into retry loop).

@nstogner nstogner added the bug Something isn't working label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant