Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get stats and autoscale deployments with model annotation #77

Open
samos123 opened this issue Feb 10, 2024 · 0 comments
Open

Only get stats and autoscale deployments with model annotation #77

samos123 opened this issue Feb 10, 2024 · 0 comments

Comments

@samos123
Copy link
Contributor

samos123 commented Feb 10, 2024

Currently this will be seen in the logs

Kubernetes service which has no deployment:

2024/02/10 19:51:42 Average for deployment: kubernetes: 0 (ceil: 0), current wait count: 0
2024/02/10 19:51:42 SetDesiredScale(0), current: -1, min: 0, max: 0
2024/02/10 19:51:42 Scaling up to 0 immediately                                                                 
2024/02/10 19:51:42 Scaling model "kubernetes": 0                                                               
2024/02/10 19:51:42 error scaling: get: Deployment.apps "kubernetes" not found
2024/02/10 19:51:42 Is leader, autoscaling       
2024/02/10 19:51:42 Average for deployment: lingo: 0

Lingo which has a deployment but no annotation:

2024/02/10 19:51:45 Average for deployment: lingo: 0 (ceil: 0), current wait count: 0
2024/02/10 19:51:45 SetDesiredScale(0), current: -1, min: 0, max: 0
2024/02/10 19:51:45 Scaling up to 0 immediately
2024/02/10 19:51:45 Scaling model "lingo": 0
2024/02/10 19:51:45 error scaling: not scaling deployment "lingo": deployment has no models annotation

Expected behavior:

  • The stats should only be retrieved for deployments that are actively managed by lingo any other deployments should be ignored -> ignore all deployments that do not have the model annotation

Note that solving #59 might solve this issue as well. Both could potentially be tackled in the same PR, but doesn't have to be. There might a much smaller simpler fix for this issue vs #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant