Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure a default timeout of 30 minutes #58

Open
samos123 opened this issue Jan 13, 2024 · 2 comments
Open

Configure a default timeout of 30 minutes #58

samos123 opened this issue Jan 13, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@samos123
Copy link
Contributor

Any request that's pending for more than 30 minutes should return a 408 HTTP timout error

This timeout should be configurable. A value of 0 would disable it such that there is no timeout.

@willschneider15
Copy link

Any suggestions for where you would want the implementation to go, I was thinking maybe a timer could go here:

func newProxyRequest(r *http.Request) *proxyRequest {

@nstogner
Copy link
Contributor

nstogner commented Apr 4, 2024

I am not up to speed on the correct implementation off the cuff so I skimmed this article and it looks pretty informative: https://ieftimov.com/posts/make-resilient-golang-net-http-servers-using-timeouts-deadlines-context-cancellation/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants