Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark fraud proof validation in pre_dispatch #2620

Open
NingLin-P opened this issue Mar 15, 2024 · 0 comments
Open

Benchmark fraud proof validation in pre_dispatch #2620

NingLin-P opened this issue Mar 15, 2024 · 0 comments

Comments

@NingLin-P
Copy link
Member

Currently, the weight of the submit_fraud_proof extrinsic only covers the handling part of the fraud proof (i.e. prune bad ER, slash submitter and revert head receipt number, etc) while the fraud proof verification is also expensive compared to other normal extrinsic, thus we should benchmark the fraud proof verification in pre_dispatch and add the resulting weight to the submit_fraud_proof extrinsic.

However, there is an obstacle because the fraud proof verification involves the host function for querying block history and old state, etc, from the client side, which is hard to simulate in the benchmark, and also the current benchmark infra is more about benchmarking the runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant