Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RPC node client and disable RPC on the node #27

Closed
nazar-pc opened this issue Dec 11, 2023 · 0 comments · Fixed by #192
Closed

Replace RPC node client and disable RPC on the node #27

nazar-pc opened this issue Dec 11, 2023 · 0 comments · Fixed by #192
Assignees
@dastansam
Labels
backend Backend logic good first issue Good for newcomers node Consensus node functionality refactoring Changes that do not bring new features, but make some possible

Comments

@nazar-pc
Copy link
Member

nazar-pc commented Dec 11, 2023 •
edited by dastansam

Right now for simplicity application reuses NodeRpcClient, but it is fragile in case port is already occupied as well as provides unnecessary security risk.

This should be replaced with node client that works with node directly and RPC server on node should probably be disabled completely.
@nazar-pc nazar-pc added good first issue Good for newcomers backend Backend logic node Consensus node functionality refactoring Changes that do not bring new features, but make some possible labels Dec 11, 2023
@nazar-pc nazar-pc mentioned this issue Mar 14, 2024
Closed
1 task
@dastansam dastansam self-assigned this May 3, 2024
@dastansam dastansam mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dastansam dastansam

Labels
backend Backend logic good first issue Good for newcomers node Consensus node functionality refactoring Changes that do not bring new features, but make some possible
Projects
Space Acres
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace NodeRpcClient with direct NodeClient implementation for the client subspace/space-acres
2 participants
@nazar-pc @dastansam