Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Question: Should we bust out the Styles and Import them? #911

Open
brnt-toast opened this issue Apr 29, 2023 · 0 comments
Open

Comments

@brnt-toast
Copy link
Contributor

Currently auditing pages/index.js (getting ready to migrate over to TS) and noticed that i folded about 13 styles before to getting the render function.

At this point would it make sense to externalize the styles and import them?
Other pages aren't so bad except pages/showcase.js.

Most of the components in components/ aren't bad either except for maybe a few like components/SmallShowcase/index.js

Personally I vote, yes due to the increase readability.

I would slowly work on this during my free time and the TS rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant