Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database column not removed on deactivating #9

Open
ians88 opened this issue Oct 13, 2016 · 1 comment
Open

Database column not removed on deactivating #9

ians88 opened this issue Oct 13, 2016 · 1 comment
Assignees
Milestone

Comments

@ians88
Copy link

ians88 commented Oct 13, 2016

I noticed that the row 'order' is not removed when deactivating the plugin. Isn't this desirable behavior, since now you 'polute' the database after checking a plugin out, or removing it once it is not needed anymore. Could a register_deactivation_hook be used? If so I'd be happy to do some code for it and make a pull request, but thought I'd ask first why this isn't implemented yet.

@lmoffereins
Copy link

lmoffereins commented Dec 13, 2016

I think the column should only be removed when uninstalling the plugin. I'd rather not lose data when I just deactivated this plugin - be it by accident or on purpose.

@JJJ JJJ self-assigned this Jul 30, 2020
@JJJ JJJ added this to the 2.0.0 milestone Jul 30, 2020
@JJJ JJJ changed the title Database row not removed on deactivating Database column not removed on deactivating Jul 30, 2020
@JJJ JJJ modified the milestones: 2.0.0, 3.0.0 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants