Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing a delete button ? #336

Open
Leiasticot opened this issue May 8, 2024 · 1 comment
Open

[BUG] Missing a delete button ? #336

Leiasticot opened this issue May 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Leiasticot
Copy link

Describe the bug
I didn't have any button to delete a file, and when I delete it from then files still be inside my libraries. Even inside Settings.

To Reproduce
Steps to reproduce the behavior:

  1. .cbz from a webtoon
  2. delete files from the server with rm -r
  3. Inside the library

Expected behavior
When I delete a file inside my server then it is deleted from the library (or at least use a button to not see it always).

Screenshots
image
image
image
image

Desktop (please complete the following information):

  • OS: Docker on debian 12 for server, and client is Windows 11 Chrome
@Leiasticot Leiasticot added the bug Something isn't working label May 8, 2024
@aaronleopold
Copy link
Collaborator

This isn’t necessarily a bug, there is just no delete button or logic to automatically delete books today, but I do think the issue highlights a few areas where we could define better UX in general around these situations.

If a known entity (series, book, etc) is unable to be located on disk during a scan, it’s marked as missing. I recall a few places where books may be marked as missing outside of a scan during API usage, but can’t remember where offhand.

So I guess one question would be is it desirable to update the status of books missing from disk even in some GET requests? Or should it stay as only setting the status when explicitly asked (i.e. during a scan)?

Regardless, delete/trash operations can definitely be added. Initially I’d do it per entity, but then it would be planned accordingly for #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants