Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Historical record for completion dates of books #207

Open
aaronleopold opened this issue Dec 3, 2023 · 0 comments
Open

[FEATURE] Historical record for completion dates of books #207

aaronleopold opened this issue Dec 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@aaronleopold
Copy link
Collaborator

aaronleopold commented Dec 3, 2023

Is your feature request related to a problem? Please describe.

This feature request is a subset of some of the items discussed in #206. Namely:

completed_at should be a list of dates (with at least one)... Mostly so that in the future you can look and be like "i read this on X dates" etc

Describe the solution you'd like

I don't love the idea of storing a list of dates in SQLite, since I either have to stringify it or store as bytes, so perhaps just make a small lookup table for this. Maybe rename read_progress(es) to read_session(s), I know I've been dying to rename it. The idea would then be that completion status could be tracked by something like completion_history or read_history, and read_session would track stuff like the page/epubcfi/etc.

Additional context

The changes to the schema would be somewhat small, but there would be a decent amount of changes in the API and UI required to accommodate this.

@aaronleopold aaronleopold added the enhancement New feature or request label Dec 3, 2023
@aaronleopold aaronleopold added this to the First stable release milestone Dec 13, 2023
@aaronleopold aaronleopold removed this from the First stable release milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant