New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update textdomain #39

Open

dreamwhisper opened this issue Aug 7, 2018 · 1 comment

Labels

Contributor

dreamwhisper commented Aug 7, 2018

If your plugin is hosted on wordpress.org it must be the slug of your plugin URL (wordpress.org/plugins/).

https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains

https://translate.wordpress.org/projects/wp-plugins/genesis-connect-woocommerce

dreamwhisper added needs dev task labels

Contributor

nickcernis commented Aug 9, 2018 •

edited

👍 As part of this we should also:

Update all 'gencwooc' text domain strings to 'genesis-connect-woocommerce', such as those in https://github.com/copyblogger/genesis-connect-woocommerce/blob/develop/admin/views/html-notice-needs-woocommerce.php.
Change 'requires at least' in the readme from 3.3 to 4.6 (or add load_plugin_textdomain): https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain

I checked the logs from WP Slack's #meta-language-packs channel, and they just say:

Plugin is not compatible with language packs: Missing text domain in header.

(It's not clear why it fails on this, though, because the text domain header is optional since 4.6: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#text-domains. It may be because we don't specify 4.6 as the minimum version, or it might be that the WP.org warning needs to be updated. Suggest we just add the text domain header anyway for now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment