Restore CSV download functionality on School Overview page

[alexsoble]

This story started when we noticed a client-side error report from Rollbar. Looking at the error report, it was clear that a Somerville educator had downloaded the HTML for an Insights page to their local machine.

@snoopyuri reached out to the educator. Turns out they were trying to download the HTML for the School Overview page because they wanted to work with the data in the students table. @snoopyuri and I both remembered that there used to be a "Download as CSV" link on this page, but looking in the app and the code, it's not there anymore.

I did some browsing through the commit history to find an example of that functionality. You can see it in the renderDownloadLink function in the commit version from back in April 2016:

https://github.com/studentinsights/studentinsights/blob/123088c5da7a85cd75e45ce06299adee08603d7d/app/assets/javascripts/school_overview/school_overview_page.js

@kevinrobinson, do you remember why we removed renderDownloadLink? I don't, and I haven't been able to find the commit that removed it quite yet.

Unless the reason we removed it was super-compelling, I think this would be good functionality to restore. The fact that Somerville educators are downloading HTML pages to try to duplicate this functionality shows the user need!

[alexsoble]

Looks like it moved to the SliceButton component here: ed44ef1

[alexsoble]

OK here's the PR: #804. @kevinrobinson, I forgot the exact reasoning behind this PR. Should we restore the link unless we can think of a reason we shouldn't?

[kevinrobinson]

Nice! Restoring seems good to me, I think we removed it from the PowerBI set of work because we ended up exporting more detailed data in a different way. In general it seems like a good feature in general to allow folks to download any table/roster as CSV for other analysis (and trusting educators to follow good security practices like with other student data they work with).

…

On Wed, Jan 17, 2018 at 5:06 PM Alex Soble ***@***.***> wrote: OK here's the PR: #804 <#804>. @kevinrobinson <https://github.com/kevinrobinson>, I forgot the exact reasoning behind this PR. Should we restore the link unless we can think of a reason we shouldn't? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1385 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAgvWETb59kP_mTykWCLGOQ1bzih66Cks5tLm7lgaJpZM4Rh5Gv> .

[alexsoble]

Talking with @snoopyuri and team about this — maybe we add some kind of pop up message reminder about student data confidentiality or something to the header row.

[kevinrobinson]

Code for doing this is here: 9530534. I did it in #1744 but backed it out since it had a lot of other changes.