Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB: parallel banks are receiving first bank's voltages #123

Open
jeronimo opened this issue Oct 18, 2021 · 10 comments
Open

InfluxDB: parallel banks are receiving first bank's voltages #123

jeronimo opened this issue Oct 18, 2021 · 10 comments

Comments

@jeronimo
Copy link

jeronimo commented Oct 18, 2021

Screenshot 2021-10-18 at 15 45 09

Screenshot 2021-10-18 at 15 45 17

diyBMSv4Code Release-2021-03-29-15-35
InfluxDB shell version: 1.6.4

@stuartpittaway
Copy link
Owner

Oh, that looks like an issue. I'm quite busy at the moment so may take a few days to investigate.

@jeronimo
Copy link
Author

Just wrote a quick script to send data from Victron Smartshunt via Ruby to InfluxDB and have started to look at diybms code as well. It seems that in

poststring = poststring + "cells," + "cell=" + String(bank) + "_" + String(i) + " v=" + String((float)cmi[i].voltagemV / 1000.0, 3) + ",i=" + String(cmi[i].internalTemp) + "i" + ",e=" + String(cmi[i].externalTemp) + "i" + ",b=" + (cmi[i].inBypass ? String("true") : String("false")) + "\n";
array indexes should be i+bank though not sure if cmi array already has all the values.
If it is not a quick fix I will make a PR at some point :)

@stuartpittaway
Copy link
Owner

Hello @jeronimo just checking that you are reporting this issue against the ESP8266 version of the DIYBMS controller?

This issue was resolved in the ESP32 version.

@jeronimo
Copy link
Author

Yes, I am still using old controller with Wemos D1 Mini ESP8266.

@rolfbartels
Copy link

Just confirming that this issue still exists

@stuartpittaway
Copy link
Owner

Although @rolfbartels is using the ESP32 version which has a different code base

@rolfbartels
Copy link

Sorry, just to calrify I am using the old controller with the Wemos D1 Mini ESP8266

@stuartpittaway
Copy link
Owner

Ah, in which case that's a whole different ball game!

stuartpittaway added a commit that referenced this issue May 24, 2022
@stuartpittaway
Copy link
Owner

@rolfbartels just updated the code, do you want to try that one out?

@rolfbartels
Copy link

@stuartpittaway I can confirm, this has fixed the error, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants