Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single docker image for node.js and ngnix #67

Open
ozairs opened this issue Apr 27, 2017 · 1 comment
Open

Single docker image for node.js and ngnix #67

ozairs opened this issue Apr 27, 2017 · 1 comment

Comments

@ozairs
Copy link
Collaborator

ozairs commented Apr 27, 2017

The current API microgateway combines ngnix and node.js using a docker compose file, which results in two separate container instances. We should use a single docker image that runs both processes within a single container. This can be done using supervisord, and still leverage Dockerfile for building each Docker image (node.js & ngnix).

@mhamann
Copy link

mhamann commented Apr 27, 2017

Maybe. You're then combining a theoretically multi-tenant front-end (nginx) with a decidedly single-tenant backend (node.js microgateway). I suppose it should be possible to run them in a single container, but I doubt if that should be done for anything real-world.

There is also a non-trivial cost in terms of image size and complexity to running supervisord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants