Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't provide 'now' or 'unchanged' to Upcoming Invoice API #1336

Closed
metanoic opened this issue Oct 17, 2018 · 4 comments
Closed

Can't provide 'now' or 'unchanged' to Upcoming Invoice API #1336

metanoic opened this issue Oct 17, 2018 · 4 comments
Assignees

Comments

@metanoic
Copy link

So, the StripeUpcomingInvoiceOptions object has SubscriptionBillingCycleAnchor as a DateTime?, which doesn't afford the ability to specify 'now'. This is in contrast to StripeSubscriptionUpdateOptions's bool properties of BillingCycleAnchorNow and BillingCycleAnchorUnchanged.

I think StripeUpcomingInvoiceOptions should implement this like StripeSubscriptionUpdateOptions does.

If the maintainers are willing to accept a PR, I'm fine with doing the work though I may need assistance with updating the tests.

@remi-stripe
Copy link
Contributor

@metanoic Thank you for the report. Usually we would happily take a PR but we are actively working on the next major release of stripe-dotnet which contains a large number of changes. You can see the work in #1293. Because of this, it might be tricky for you to make the changes on that branch, and rebasing on an updated master would be fairly painful (though not impossible).

I'm going to make the changes on that branch which we're hoping to release by early next week if that works for you!

@remi-stripe remi-stripe self-assigned this Oct 17, 2018
@remi-stripe
Copy link
Contributor

@metanoic I just realized that this was already done in that PR and you can see the new code here. This should be released soon!

@metanoic
Copy link
Author

@remi-stripe Excellent; ya'll rock!

@ob-stripe
Copy link
Contributor

Fixed in 20.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants