Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardService.List does not load data from source type="card" #1062

Closed
wize1 opened this issue Nov 28, 2017 · 5 comments
Closed

CardService.List does not load data from source type="card" #1062

wize1 opened this issue Nov 28, 2017 · 5 comments

Comments

@wize1
Copy link

wize1 commented Nov 28, 2017

I have customer stored with 3 sources with type = "card", when calling StripeCardService List method i get back 3 instances of the object of StripeCard, but properties of that object are not populated.

All of the properties of StripeCard has values set to null, except for Id, CustomerId and Object those 3 have correct values.

@ob-stripe
Copy link
Contributor

So there are two different issues here:

  1. StripeCardService.List should only return card objects (cf. StripeCardService.List() deserializing all types of sources as Card objects #989), not source objects (even source objects with type=card)

  2. The library currently does not have a method for querying source objects attached to a customer.

I've pushed a fix for the second issue in #1064. The first issue is a bit trickier as some users might rely on the current broken behavior, and so will likely require a major version bump.

@ob-stripe
Copy link
Contributor

Hey @wize1, we just released v11.9.0 which includes the fix I mentioned above.

You should now be able to retrieve card sources on a customer like this:

var SourceService = new StripeSourceService();
var ListOptions = new StripeSourceListOptions
{
    Type = StripeSourceType.Card
};
var CardSourceList = SourceService.List("cus_...", ListOptions);

@wize1
Copy link
Author

wize1 commented Nov 29, 2017

Thank you ob-stripe!

That helps alot! Very rapid development ;)

When do you thing I will be able to get it on nuget?

@ob-stripe
Copy link
Contributor

It should be available now :)

@wize1
Copy link
Author

wize1 commented Nov 29, 2017

installed, tested and satisfied! :) you guys rock, i got it in perfect time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants