Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending runtime dependency on Stripe gem from version 5 through 11 #848

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Extending runtime dependency on Stripe gem from version 5 through 11 #848

merged 6 commits into from
Feb 10, 2024

Conversation

smakani
Copy link

@smakani smakani commented Nov 15, 2022 •
edited

Closes #847

@smakani smakani changed the title #847 Extending runtime dependency on Stripe gem from version 5 until 7.1 Extending runtime dependency on Stripe gem from version 5 until 7.1 Nov 15, 2022
@smakani smakani changed the title Extending runtime dependency on Stripe gem from version 5 until 7.1 Extending runtime dependency on Stripe gem from version 5 through 7.1 Nov 15, 2022
@smakani smakani mentioned this pull request Dec 26, 2022
Open
@smakani
Copy link
Author

smakani commented Dec 26, 2022

This PR fixes issue #847. Please upvote to get it merged.

@courtsimas
Copy link

how about through 8, now.

@tot-ioki tot-ioki mentioned this pull request May 2, 2023
Merged
@barsbek
Copy link

barsbek commented May 3, 2023

Extending to the latest version would be really helpful

lukeasrodgers added a commit to alice-financial/stripe-ruby-mock that referenced this pull request Dec 13, 2023
@lukeasrodgers
Relax stripe gem dependency
cbdb1de 
Various other PRs report success with this, e.g. stripe-ruby-mock#848
@alexmamonchik alexmamonchik changed the base branch from master to init-v4 February 10, 2024 09:36
alexmamonchik
alexmamonchik approved these changes Feb 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
stripe-ruby-mock.gemspec Outdated Show resolved Hide resolved
@alexmamonchik alexmamonchik reopened this Feb 10, 2024
@alexmamonchik
Copy link
Contributor

@smakani please, solve conflicts and use init-v4 branch. We'll collect all required fixes for v4 and newest Stripe. Then merge it to master and release

@smakani smakani changed the title Extending runtime dependency on Stripe gem from version 5 through 7.1 Extending runtime dependency on Stripe gem from version 5 through 11 Feb 10, 2024
@alexmamonchik alexmamonchik merged commit 1714394 into stripe-ruby-mock:init-v4 Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmamonchik alexmamonchik alexmamonchik approved these changes

Assignees
No one assigned
Labels
will be in v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support for Stripe gem version 7
4 participants
@smakani @courtsimas @barsbek @alexmamonchik