Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bool(trace) should handle default values #278

Open
sdementen opened this issue Mar 15, 2024 · 0 comments
Open

bool(trace) should handle default values #278

sdementen opened this issue Mar 15, 2024 · 0 comments

Comments

@sdementen
Copy link
Contributor

sdementen commented Mar 15, 2024

    def __bool__(self):
        return bool(self._d)

should probably be rewritten as

    def __bool__(self):
        return bool(self._d) or bool(trace.default)

to see if is_empty should follow a similar logic with

    def is_empty(self):
        return len(self) == 0

rewritten as

    def is_empty(self):
        return len(self) == 0 and self.default is None

but I see it is used in bin() and check_boundaries() so not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant