fix rendering on "highway=pedestrian" ways #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one of results is no longer displaying minor inner borders of pedestrian areas, like https://www.openstreetmap.org/way/304011759 (transparency difference is an unrelated issue) |
matkoniecz
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: streetcomplete#119
as found by @Helium314 in streetcomplete#119 (comment) and validated by @matkoniecz in streetcomplete#119 (comment), removing those lines fixes the problematic rendering of on
highway=pedestrianways, without making areas problematic.test .apk with manually modified app/src/main/assets/map_theme/jawg/layers/land.yaml compiles and works fine.
Here is example of both way and area for
highway=pedestrian, before and after:Confusing line in the middle of the
wayis fixed (right middle of the screenshot), whileareaon the left side is not really negatively affected.