Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing style for highway=pedestrian #119

Open
mnalis opened this issue Dec 23, 2021 · 13 comments · May be fixed by mnalis/streetcomplete-mapstyle#1
Open

confusing style for highway=pedestrian #119

mnalis opened this issue Dec 23, 2021 · 13 comments · May be fixed by mnalis/streetcomplete-mapstyle#1
Labels

Comments

@mnalis
Copy link
Member

mnalis commented Dec 23, 2021

highway=pedestrian has strange style, with divider line in the middle, which makes it look like two streets.

small_Screenshot_20211223_165022_de westnordost streetcomplete mn debug

It is confusing to users, eg. https://www.openstreetmap.org/note/2259724 or https://www.openstreetmap.org/note/2974300

Perhaps it could be drawn to look more like regular footway?

@westnordost
Copy link
Member

Sounds like a bug. I can not remember there is some explicit code in the style that would do this.

@mnalis
Copy link
Member Author

mnalis commented Feb 22, 2022

Looking around at https://streetcomplete.github.io/streetcomplete-mapstyle/?provider=jawg&style=dark, the problematic "line in the middle of pedestrian street" is visible in both dark and light mode, but not in satellite mode, where it looks normal.

@Helium314
Copy link
Contributor

The responsible part is

lines:
color: global.square_outline_color
width: function () { return 1/4 * Math.log($zoom); }
order: 30

which also draws the "double" outline of squares.
IMO things also look quite ok without this part

@westnordost
Copy link
Member

Hm well, the outlining works correctly with buildings, so maybe there is a bug.

@mnalis
Copy link
Member Author

mnalis commented May 7, 2022

hm, that function() is inside pedestrian-areas: yaml section, and highway=pedestrian (which this issue is about) can be used not only as a way, but also as an area. Could that be related to the problem?

i.e. that style should be applied only to areas, and not to regular (non-closed) ways?

@Helium314
Copy link
Contributor

Hm well, the outlining works correctly with buildings, so maybe there is a bug.

It looks like outlines of squares are displayed as roads. When excluding pedestrian roads from normal road style, the outlines of squares are nice, but then of course non-area pedestrian roads are not displayed properly (only as line with square_outline_color).

@michaelblyons
Copy link

hm, that function() is inside pedestrian-areas: yaml section, and highway=pedestrian (which this issue is about) can be used not only as a way, but also as an area. Could that be related to the problem?

i.e. that style should be applied only to areas, and not to regular (non-closed) ways?

The extra bubbling outward of the area is also ugly in the places where I encounter it. Mostly around swimming pools, but a couple other places too.

@matkoniecz
Copy link
Member

@Joxit Is there any possibility to distinguish "outline of highway=pedestrian area=yes area" and "highway=pedestrian line"?

From what I see Jawg data is not allowing this.

@matkoniecz
Copy link
Member

I tried removing

                lines:
                    color: global.square_outline_color
                    width: function () { return 1/4 * Math.log($zoom); }
                    order: 30

and I think that with current limitations it is overall an improvement.

Though one of results is no longer displaying minor inner borders of pedestrian areas, like https://www.openstreetmap.org/way/304011759

(transparency difference is an unrelated issue)
screen11

@westnordost
Copy link
Member

@matkoniecz what data is exactly in the jawg tile set is documented here:

https://www.jawg.io/docs/apidocs/maps/streets-v2/

Note the map on top, you are able to zoom in and inspect exactly what tags are set on the individual objects.

@matkoniecz
Copy link
Member

Note the map on top, you are able to zoom in and inspect exactly what tags are set on the individual objects.

I did this to confirm that there is nothing allowing distinguishing them.

screen12
screen14

(oneway and presence of names is not reliable indicator)

@Joxit
Copy link

Joxit commented Oct 15, 2022

Hi there, so you want to distinguish a Line from a Polygon ? With MapLibre GL, the style spec allow us to apply style on LineString or Polygon, is that you are looking for ?

@mnalis
Copy link
Member Author

mnalis commented Oct 15, 2022

@Joxit yes, the intention is to distinguish from highway=pedestrian way and highway=pedestrian polygon (i.e. closed way, area), which currently seems to be impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants