Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all quests for element at once #124

Open
Qwertie- opened this issue Apr 17, 2017 · 50 comments
Open

Show all quests for element at once #124

Qwertie- opened this issue Apr 17, 2017 · 50 comments

Comments

@Qwertie-
Copy link
Contributor

Sometimes there are multiple quests for the same thing like adding the name of a road and then adding the surface. It would be handy to have the next quest load up right away as you are already looking at this object. A skip button would also be needed if the user can't/doesn't want to answer one of the questions.

@westnordost
Copy link
Member

There is a skip button. Press "Other answers" -> "Can't Answer". It allows you to leave a note (a note hides this quest for all other users as well as long as the note is open) or "Just Hide" it for yourself.

@Qwertie-
Copy link
Contributor Author

By skip I mean if you were showing multiple quests at once maybe you cant see a road name but you can see what the surface is.

The icon could show a number in the corner to show how many quests are available for the object too

@westnordost
Copy link
Member

Ah, I see. Hmm, difficult to implement, but no doubt a valid and good feature request.

@westnordost westnordost changed the title Solve all quests for object at once Show all quests for element at once Apr 17, 2017
@HolgerJeromin
Copy link
Contributor

In my opinion the base app could have a storage for each element where each quest can add elements and register itself to this element.

So if you select this element on the map you could swipe between all registered quests for this element.

With this infrastructure most quests would not unlock others.
Plain residential buildings would be registered in the housenumber, level and roof quests. You can answer all in one go.
Would solve #221 too

@rugk
Copy link
Contributor

rugk commented Jun 30, 2017

Indeed I just wanted to open a very similar issue for that:
When an object has multiple quests (e.g. in case of a street: street name, paving, etc.) it would be nice to let the user cycle through all quests available…
To some extend this issue depends on #164.

@natrius
Copy link

natrius commented Oct 21, 2017

A "1/5" (1 from 5 quests) kind of thing in the corner would be nice.

Nobody would complain imho, because after 3 points you know it and take it as it is. And you just input one quest and wait for another to display on the same spot. If not, you just going to move on.

@smichel17
Copy link
Member

smichel17 commented Feb 3, 2018

I would like to see all available quests even if I still have to answer them one at a time. The use case is:

Recently I was going somewhere in the car, in the passenger seat, and doing some mapping on the way. As we passed a street I could glance down it and was sometimes able to complete some of its quests. However, it was also quite common that I did not remember to make a note of some characteristic because I did not know that quest was active and could not complete the visible quest in time to be able to look down the street again for additional information. It would be great if I could look down the street, figure out the answers to the quests, and then answer them after I have driven past.

Another use case is, while walking around, some quests can be answered instantly ("Does this street have lighting" or "What is the surface of this road"), while others require you to walk to the end to verify them ("What is the speed limit for this road", if the answer is "No sign"). It's nice to be able to gather all the information while walking down the street the first time and not have to turn back.

@georg-d
Copy link

georg-d commented Dec 19, 2018

There is a skip button. Press "Other answers" -> "Can't Answer". It allows you to leave a note (a note hides this quest for all other users as well as long as the note is open) or "Just Hide" it for yourself.

Until reading this, I was not understanding this is intended as a skip button => I opened #1296

@Echolon
Copy link

Echolon commented Oct 3, 2020

@westnordost can you explain what is so complicated to query through the quest per e.g. street or building?

Or what I also have in mind, to swap through quests which are hidden by other quests but are not even shown when zoomed in till the end.

@rouelibre1
Copy link

@westnordost : I believe this is the same topic that has been debated multiple times, and if I get it right in a nutshell the status is : "High complexity, has already been tried and rolled back, won't implement again, #1874 should provide a technical improvement to the situation without implementing the described feature".

In this case, should this issue remain opened or should it be closed ?

@westnordost
Copy link
Member

westnordost commented Oct 24, 2020

The feature request this ticket would be about now is the following:
Display all the quests that are available for this positions at the same time on the map, without one quest occluding the other and have them somehow all be selectable.

What has been done before until now

  1. Directly unlock next quest after uploading the answer for one (for most but not all quests) without a new download
  2. Skip directly to the next quest for the same element after answering the first. Didn't work out that well and was reverted later.
  3. Starting at a specific zoom level, show quest pins that would normally be occluded by another quest pin as little white dots

So, I'd say this issue can remain open because the feature request as emphasized in this comment is a valid one and maybe not impossible to implement. It should only be closed if there is a good reason why the suggestion would likely go down like another lead ballon (like point 2)

@Echolon
Copy link

Echolon commented Oct 24, 2020

Do you guys remember those computer games screen where you were able to have a "rotating selection" with a selection of choices?
Something like this would be a nice UI.

@westnordost
Copy link
Member

westnordost commented Oct 24, 2020

secret_of_mana_snes_menu1
?

This'd mean that for every place where there are several quests, it is always one tap more to actually solve the quest.

@Echolon
Copy link

Echolon commented Oct 24, 2020

Yes, or something like this: https://www.youtube.com/watch?v=cA0ePIfKBcY
I dont think that should be shown first hand. But if you swipe left or right it might bring such a view to the screen? Or a klittle arrow symbol as function to enable a potential quest selection.

@westnordost
Copy link
Member

But swiping already moves the map. It would be very irritating if it only moves the map if your finger is not on a quest pin.

@Echolon
Copy link

Echolon commented Oct 25, 2020

Sorry, I meant once you clicked a quest and see the quest describtion. In that menu, when you may decide that you cannot answer a quest, you should be able to swipe to the next potential one.

The quest menu is a fixed centered view already, so that should be possible, technically.

@timothywashere
Copy link

What if the (new) quest selection menu was only opened by doing a long press on the quest shown on the map, then it wouldn't take up any space whatsoever unless you wanted it and it's unlikely novice users would ever see it and get confused

@mnalis
Copy link
Member

mnalis commented Oct 9, 2021

What if the (new) quest selection menu was only opened by doing a long press on the quest shown on the map, then it wouldn't take up any space whatsoever unless you wanted it and it's unlikely novice users would ever see it and get confused

Do note however that long press anywhere on the map is already used (and displays menu with two possible actions). I guess it probably could detect if there is quest below, and then open the menu with three options instead of two, but implementing that might turn out to be problematic...

@peternewman
Copy link
Collaborator

Also, looking at it reveals one potential confusion: this quests are not yet available and may not become aailable. Housenumber quest is available only after building type was specified, roof shape only after building levels was answered, street quest only after housenumber was set.

It could show the currently available one(s) and add more as they're enabled (by answering further quests).

FWIW I've been using the new undo hiding functionality recently to do this loads, it would be great if say @smichel17 's list of them could just appear at the top of the screen when you tap the first quest. It could at least cover the star count and probably announcements and upload and could even be scrollable to see more quests. No lost screen real estate, but far quicker to get back than the current toggle:
Other Answers
Can't Say
No, Just Hide
Undo
Undo that quest
Really Undo

If I'm wandering I'll often tag the obvious or timely thing (e.g. well signposted Halal, or traffic light sounder) but I want the other quests unhidden again in case I get a chance to look for a traffic light touch or read the menu.

@rugk
Copy link
Contributor

rugk commented Nov 20, 2021

It could show the currently available one(s) and add more as they're enabled (by answering further quests).

…or it could show them greyed out…

And as gesture-navigation seems to be the new trend/hype (see e.g. the new Android versions – I personally got quite comfortable with gesture navigation through apps), as for the UX, it could be a simple slide right/left for previous/next quest or so… if one question is currently shown.

@peternewman
Copy link
Collaborator

It could show the currently available one(s) and add more as they're enabled (by answering further quests).

…or it could show them greyed out…

I think that's inherently quite technically complicated based on the quest metadata we currently store. We don't explicitly store which tags a quest adds, or which ones it requires, so working out which ones to show would be pretty involved. You could obviously show ALL the quests and just grey out the disabled one, but that feels like it's going to be a lot of noise and scrolling to me, you just want to see the ones you can do.

And as gesture-navigation seems to be the new trend/hype (see e.g. the new Android versions – I personally got quite comfortable with gesture navigation through apps), as for the UX, it could be a simple slide right/left for previous/next quest or so… if one question is currently shown.

How do you indicate that there are more to select (versus this being the last/only quest available), some arrows or something?

@rugk
Copy link
Contributor

rugk commented Nov 22, 2021

How do you indicate that there are more to select (versus this being the last/only quest available), some arrows or something?

Hmm yeah maybe. And at the end of the "list" there could be some bumper animation just like if you scroll on Safari "too far" on a website and it bumps back, if you get what I mean.
Anyway, I guess these are (UI) details, the hard part to tackle seem to be the technical stuff further down the application layers🙃

@riQQ riQQ mentioned this issue Apr 9, 2022
@basings
Copy link

basings commented Apr 20, 2022

I'd also be interested in a multi-question mode because of some comments mentioned here and especially because I can answer multiple quests within "a second" but I need to wait for it to finish and in the worst case it zoomed into/out of the map which takes "forever" if you just want to input info.

@matkoniecz
Copy link
Member

matkoniecz commented May 25, 2022

@mdtrooper has a really nice mockup how it could look like (from #4060 (comment) )

Though note that it would require extra clicking to get access to any quest.

Also, this specific case will never happen: if building type quest is not solved, then neither roof nor address quest is eligible.

example2

@mdtrooper
Copy link

And I made another image with the pin grouped 3 quest:

Pin shows 3 quest overlaped
example

@mnalis
Copy link
Member

mnalis commented May 29, 2022

@mdtrooper has a really nice mockup how it could look like (from #4060 (comment) )

Though note that it would require extra clicking to get access to any quest.

Yes, it looks nice, but extra click is definitely a deal breaker IMHO. Perhaps if that UI can be invoked some other way (i.e. click on originally offered quest, and have extra icon (or menu entry) to show other quests for this element, or something like that?)

Also, while not directly this specific problem, there is an related issue of quests hidden by nearby quest which are then impossible to select (as we cannot zoom in enough - see #2878).

It would be great if there was and idea which would solve both problems at once - i.e. somehow allow selecting any quest under my finger: which might be either

  • "all other quests for currently shown element", or
  • "all quests for element at extremely close position to currently selected element" (which is hidden as small dot)

@Helium314
Copy link
Collaborator

Solution inspired by #3108 (though I put the list on the right, which I find more convenient)
im

@smichel17
Copy link
Member

smichel17 commented Oct 9, 2022

Initial impression, as compared to my idea upthread:

  • I like the vertical list along the right side rather than a horizontal list at the top.
    • As pictured, it would block the compass icon, though.
  • I worry about how much screen space we are taking up with UI elements instead of the map. I think the quests list should be toggle-able.
    • This would also make blocking the compass icon a non-issue.
  • I like the color coding for indicating which quests corresponds to which element. However, it doesn't seem tailored toward solving the original problem— being able to solve quests for an element which are blocked/"covered" by a higher-priority quest. I guess it helps with selecting quests which are only visible as dots?
    • In any case, if this interface is used anywhere, I would suggest adding a colored ring around the side to make it even more obvious that the color coding corresponds to quests (it took me a minute to figure it out). Rough mockup:
      image

@HolgerJeromin
Copy link
Contributor

As pictured, it would block the compass icon, though

Many (all?) quests leave the (+) Icon available which is an important thing IMO.

@Helium314
Copy link
Collaborator

As pictured, it would block the compass icon, though.

Actually the compass is disabled while the quests are shown.

I think the quests list should be toggle-able

It is optional.

I would suggest adding a colored ring

Thanks, that's definitely better than just coloring the icons. Added.

Many (all?) quests leave the (+) Icon available which is an important thing IMO.

On above screenshot you can see that this is not the case. Only the yes/no questions don't block it, if the question is short enough.

@rhhsm
Copy link

rhhsm commented Jan 24, 2023

What if the (new) quest selection menu was only opened by doing a long press on the quest shown on the map, then it wouldn't take up any space whatsoever unless you wanted it and it's unlikely novice users would ever see it and get confused

Do note however that long press anywhere on the map is already used (and displays menu with two possible actions). I guess it probably could detect if there is quest below, and then open the menu with three options instead of two, but implementing that might turn out to be problematic...

Just found this discussion, and the above is the best idea so far, I think. If a distinction is already made between a short tap on a quest icon and a short tap somewhere else, then distinguishing between a long press on a quest icon and a long press somewhere else should not be difficult, I guess. It could show a list of accessible quests in a format similar to the revert menue.

@mnalis
Copy link
Member

mnalis commented Jun 21, 2023

Though note that it would require extra clicking to get access to any quest.

Just to note that SCEE does have extra Settings / UI / Show next quest immediately which triggers next quest for same element automatically, as soon as previous quest is solved.

@opk12
Copy link

opk12 commented Oct 2, 2023

What about this:

  1. Summarize all quests in a form similar to this screenshot from BikingImprover, replicated below for convenience. (It's a StreetComplete-inspired editor specialized in bike infra, here are other screenshots)

  2. When I tap on a text field, the form disappears and the quest-specific bottom sheet pops up.
    So they are not real text fields, they are buttons in disguise.
    (Maybe BikingImprover does this better? I don't know)

  3. When the quest is answered, the summary form appears again and the fake text field is filled with the answer.

  4. Click anywhere on the map to make the form disappear.

Questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests