Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Bash Style Guide #3

Open
Daemontamer opened this issue Mar 25, 2018 · 2 comments
Open

Adopt Bash Style Guide #3

Daemontamer opened this issue Mar 25, 2018 · 2 comments

Comments

@Daemontamer
Copy link
Collaborator

Here's the bash style guide I was referring to:

https://google.github.io/styleguide/shell.xml

Shall we adopt it moving fwd and retrofit our existing stuff as time allows?

@colleenkhenry
Copy link
Collaborator

Sounds good to me. I think some day I will just sit down and crush a red bull and implement this.

Then again... there are like.. bash beautification tools out there... I wonder if one can do that automatically for us?

@vaage
Copy link
Contributor

vaage commented Dec 17, 2018

If I could chime in, I would like to suggest transitioning away from bash, rather than investing more into bash.

While bash is very useful for projects with little complexity, it become unwieldy as complexity grows. Transitioning over to a language like python would allow for better readability, maintainability, and portability while not affecting the overall efficiency of the tool.

Moving to a language like python would allow for you to easily add argument controls via the argparse library and would allow you to easily adopt plugins for different parts of the pipeline (for example using Shaka Packager for packaging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants