Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strawberry cannot correctly display russian names from flac after drag'n'dropping .cue file to queue #1429

Closed
3 tasks done
soredake opened this issue Apr 23, 2024 · 6 comments
Assignees

Comments

@soredake
Copy link

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
Strawberry cannot correctly display russian names from flac after drag'n'dropping .cue file to queue

To Reproduce
Drag'n'drop .cue with russian names to strawberry.

Expected behavior
This:
image

Screenshots:
image

System Information:

  • Operating system: Windows 11 Pro
  • Strawberry Version: 1.0.23

Additional context
Add any other context about the problem here.

@jonaski
Copy link
Member

jonaski commented Apr 23, 2024

What encoding is the cue file in? I suspect it only supports UTF-8.

@soredake
Copy link
Author

Visual Studio Code displayed this encoding:
image

@jonaski
Copy link
Member

jonaski commented Apr 26, 2024

Can you paste the .cue file here and I will check if we can implement handling of more encodings, or at least show an error if it's not UTF-8.

@soredake
Copy link
Author

@jonaski
Copy link
Member

jonaski commented May 18, 2024

Qt only detects UTF encodings, so we need to write our own code, or use a another library (ICU or libmagic?) for that.
QTextStream::setCodec is gone in Qt 6, we need to use QTextStream::setEncoding, but it doesn't have support for all the encodings (https://bugreports.qt.io/browse/QTBUG-109254), looks like there is some work done for that here: https://codereview.qt-project.org/c/qt/qtbase/+/429820

@jonaski
Copy link
Member

jonaski commented May 18, 2024

And I wonder how KDE does this? kate detects the encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants