Summary activities #504
Closed
Summary activities #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: upgrade 2.x Fix: things are starting to work
Update src/stravalib/client.py
Remove: enum functions from stravalib Fix: tests broken because of removed mixin
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
Co-authored-by: Jonatan Samoocha <jsamoocha@yahoo.com>
* Removes BackwardCompatibilityMixin and related _field_conversions attributes * Fixes typing issues
This should prevent confusion for users about the detail level of an API response object and improve static type checking accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny PR to show how making the Strava type hierarchy explicit in our client responses can improve type-checking accuracy and prevent user confusion (see #494).
This approach can be used to resolve #499.