Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stravalib2.0 -> Maintain Strava's meta-summary-detailed type hierarchy #499

Open
2 tasks
jsamoocha opened this issue May 11, 2024 · 4 comments
Open
2 tasks

Comments

@jsamoocha
Copy link
Collaborator

jsamoocha commented May 11, 2024

This should prevent response objects with many None fields and make it more explicit to users what level of detail they'll get from an API call.

  • Update client methods to ensure the correct detail level is returned
  • Check the model for instances where we override stuff from other than detailed-level objects

Depends on #498

Update: As a reminder: this will also close #198

@lwasser
Copy link
Collaborator

lwasser commented May 11, 2024

it will be a lot less confusing to have fewer of these empty response objects. Will this also then address the comment in our discussion surrounding laps? i still haven't had a chance to look into that but i have noticed empty returns.

@jsamoocha
Copy link
Collaborator Author

Yes, exactly. We discussed this some time ago, and this recent issue triggered me to fix this now that we remove that BackwardCompatibilityMixin and introduce breaking changes anyway.

@lwasser
Copy link
Collaborator

lwasser commented May 12, 2024

perfect! i tested this and it's working well lately via your latest pr!! so much better!

@lwasser
Copy link
Collaborator

lwasser commented Jun 1, 2024

Client methods that return iterators


  • get_athlete ?

@lwasser lwasser mentioned this issue Jun 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants