Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of Activity.TYPES attr in model.py #400

Open
lwasser opened this issue Aug 11, 2023 · 1 comment
Open

Deprecation of Activity.TYPES attr in model.py #400

lwasser opened this issue Aug 11, 2023 · 1 comment

Comments

@lwasser
Copy link
Collaborator

lwasser commented Aug 11, 2023

In the model.py module there is a attr that was added for backward compatibility

    # Added for backward compatibility
    # TODO maybe deprecate?
    TYPES: ClassVar[Tuple[Any, ...]] = get_args(
        ActivityType.__fields__["__root__"].type_
    )

It might be best to deprecate this as discussed here in the review of #387

@lwasser
Copy link
Collaborator Author

lwasser commented Apr 18, 2024

this seems like a small issue that one of us would be able to knock out easily! @enadeau you and i had discussed this back in august. Should we remove the types attr in model.py? Strava now favors sport_type over type. But i'm not sure if this will break things or not for some users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant