Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create guidelines for what version of python we support #301

Open
lwasser opened this issue Dec 15, 2022 · 4 comments
Open

Create guidelines for what version of python we support #301

lwasser opened this issue Dec 15, 2022 · 4 comments

Comments

@lwasser
Copy link
Collaborator

lwasser commented Dec 15, 2022

I've been chatting with colleagues and a standard for python spuport is the NEP-29 protocol

I suggest that we follow that policy in terms of dropping older versions of python to adhere to the broader community's approach. This actually is perfectly inilne with the drop that we just made for python 3.7.

What do you all think about implementing this as a development / release policy?
Python end of life map here:.

essentially we'd then support python versions released in the past 3.5 years (42 months) to align with a broader community of packages.

@enadeau
Copy link
Contributor

enadeau commented Aug 22, 2023

I think it's a good idea to adhere to this broader standard. The fact that pint also follows this is also pushing me in that direction. Seems like a good compromise between being able to use modern feature and support many versions of python

@lwasser
Copy link
Collaborator Author

lwasser commented Aug 23, 2023

i agree. i am happy to add this to the dev guide documentation. i think i opened this when i was initially thinking about dev and writing our dev guide.

we can be a bit less aggressive too if we wish about dropping versions but 3.8 is fairly dated at this point. so i'd feel ok with us dropping it now especially given the issues you're running into !

@enadeau
Copy link
Contributor

enadeau commented Aug 23, 2023

Nice let's move forward with this I can take care of the PR that removes support for 3.8

@enadeau enadeau mentioned this issue Aug 23, 2023
10 tasks
@lwasser
Copy link
Collaborator Author

lwasser commented Aug 23, 2023

i created a quick query to look at downloads. the tool i used didn't specify the timeframe for a stock query but i'm guessing a month based on our typical weekly downloads. most of our users are on 3.9 so i feel good about this drop. perhaps it will encourage folks to upgrade as well as 3.11 is the current recommended version!

i'll be able to look more closely at your pr, @enadeau soon! i just wanted to share this as i was curious.

python_version download_count
3.9 15,152
3.8 2,924
3.10 1,676
3.11 1,604
3.7 1,131
2.7 40
3.6 10
3.12 3
Total 22,540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants