Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolling down the navbar at top should hide automatically #200

Open
0xSaksham opened this issue Mar 11, 2024 · 6 comments
Open

When scrolling down the navbar at top should hide automatically #200

0xSaksham opened this issue Mar 11, 2024 · 6 comments
Labels

Comments

@0xSaksham
Copy link
Contributor

The navbar should hide to read to allow the user to read docs in an immersive manner.

image

@pavlenex
Copy link
Collaborator

It's a sticky header? I don't see how making it unstick enhances experience? It can potentially be made a bit less wide as proposed in #171 , but still I think this is really subjective.

@0xSaksham
Copy link
Contributor Author

It blocks the view of documentation.

What I propose is that if the user is scrolling down, then it should disappear.

And If the user scrolls up, it can appear.

@pavlenex
Copy link
Collaborator

pavlenex commented Mar 12, 2024

I mean yeah, that's the point of the sticky navbar, it's not a bug. It's there so it highlights call to actions clearly.

What I propose is that if the user is scrolling down, then it should disappear.

Sure if you want do a PR and let's see how it plays out.

@0xSaksham
Copy link
Contributor Author

I'll make a PR as soon as possible. I've never worked with VueJS or Vuepress. Hence it is taking me time to quickly grasp what I need to do for every issue. But it's fun tbh!

@Aashutoshbro
Copy link

We only need to hide the navbar onScroll, Yes?

@pavlenex
Copy link
Collaborator

pavlenex commented May 6, 2024

Me and @omerskywalker chatted about this apparent issue, but this is not really an issue in our conclusion. Having a sticky nav provides better navigation for users and doesn't seem to distract as originally reported. Let's see if solution proposed in #215 leads to satisfactory or more complex experience, if later proves to be the case, we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants