Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDC executes fallback system too frequently #901

Closed
GitGab19 opened this issue May 8, 2024 · 1 comment · Fixed by #904
Closed

JDC executes fallback system too frequently #901

GitGab19 opened this issue May 8, 2024 · 1 comment · Fixed by #904
Assignees
Labels
bug Something isn't working sv2 pool
Milestone

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented May 8, 2024

While digging into issue #844, I discovered that JDC enters in the fallback mechanism too frequently.
I discovered the reason for that, and it's related to the prev_hash contained in shares.

  • Sometime (I still don't know exactly why) a valid share is sent to the pool (in this case through JDC) with the correct prev_hash.
  • When the valid share is checked by the pool, the pool uses a wrong prev_hash in the check_target function, and so the share is not a valid one for the pool.
  • Pool sends a SubmitShareError message to JDC
  • JDC thinks that Pool is wrongly refusing the valid share and pool-fallback is started

JDC logs:
Screenshot 2024-05-08 at 18 25 43

Pool logs:
Screenshot 2024-05-08 at 18 26 48

@pavlenex
Copy link
Collaborator

Done in #904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sv2 pool
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants