New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP: Send all intermediate hashes #28

Open

ccdle12 opened this issue Nov 1, 2023 · 0 comments

ccdle12 commented Nov 1, 2023

Update the TP to send all intermediate merkle hashes: https://github.com/ccdle12/bitcoin/blob/2023.10.29-sv2/src/node/sv2_messages.cpp#L33

This is the area of code where merkle roots are calculated: https://github.com/ccdle12/bitcoin/blob/2023.10.29-sv2/src/consensus/merkle.cpp

In the merkle tests, there is an old function which returned all the calculated intermediate merkle hashes: https://github.com/ccdle12/bitcoin/blob/2023.10.29-sv2/src/test/merkle_tests.cpp#L131

Maybe we need to reuse that function to be able to get and send all intermediate merkle hashes in a block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment