Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for AI VPN module: mod_comm_send #58

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add unit test for AI VPN module: mod_comm_send #58

wants to merge 6 commits into from

Conversation

Adity20
Copy link
Contributor

@Adity20 Adity20 commented Mar 23, 2024 •
edited

Pull request type

Please check the type of change your PR introduces:

  • Feature

What is the current behavior?

Closes #57

What is the new behavior?

  • This test suite verifies that the send_mime_msg_via_email function correctly sends an email with the appropriate subject and attachment when given a specific task (msg_task).
  • It mocks the SMTP server interactions to simulate sending an email without actually sending one
  • Currently the test is including only the minimal testing of the functions but later on the scope of tests will increase to edge cases, validating the email and much more.

Other information

This is for the module mod_comm_send.
Run python -u tests/test_mod_comm_send.py

@verovaleros verovaleros changed the base branch from main to develop March 27, 2024 16:43
@verovaleros verovaleros changed the title Adding a sample unit test for mod_comm_send module Add unit test for AI VPN module: mod_comm_send Mar 27, 2024
@verovaleros verovaleros added the enhancement New feature or request label Mar 27, 2024
@verovaleros verovaleros added this to the v0.1.3-beta milestone Mar 27, 2024
@verovaleros
Copy link
Member

@Adity20 thanks! 🤘🏻

  • Please move the test to a tests folder
  • Please move the file to a file that respects the naming convention, in this case tests/test_mod_comm_send.py
  • Please include one sentence with the aim of the test, what functionality are you testing.
  • Please include the command you used to run the test, so we can make sure we use the same

@Adity20
Copy link
Contributor Author

Adity20 commented Mar 27, 2024

Yeah I am on it @verovaleros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Civilsphere AI VPN Project
Status: 📋 Backlog
Milestone
v0.1.3-beta
Development

Successfully merging this pull request may close these issues.

Adding a sample unit test for module:mod_comm_send
2 participants
@Adity20 @verovaleros