Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.entries doesn't work in older browsers #5

Open
karataev opened this issue Jun 28, 2018 · 2 comments
Open

Object.entries doesn't work in older browsers #5

karataev opened this issue Jun 28, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@karataev
Copy link
Contributor

file src/helpers/index.js contains ES2017 Object.entries method which doesn't work in Safari 9.
Suggestion: refactor to make the code works in older browsers.

@stratos-vetsos
Copy link
Owner

Hi,

We should use a polyfill instead of refactoring.
Object.entries is not the only code that have issue with legacy browsers, so maybe babel-polyfill is an option, but we should check how much the bundle size will be increased.

If you have the time, a pull request will be great.
Many thanks

@karataev
Copy link
Contributor Author

karataev commented Jul 2, 2018

Yep, I used Object.entries polyfill to make the package work in older browsers.
In my case (Safari 9) Object.entries was the only thing which had to be polyfilled. The rest of the code works as expected with no errors.
Here's the polyfill I used to solve the problem (for anyone with the same issue): https://stackoverflow.com/a/45851440/5476578

Thanks for the great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants