Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2(+) controllers key mapping issue #209

Open
Intelparcel opened this issue Oct 25, 2023 · 6 comments
Open

2(+) controllers key mapping issue #209

Intelparcel opened this issue Oct 25, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Intelparcel
Copy link

Intelparcel commented Oct 25, 2023

When connecting 2 controllers at the same time, both controllers mapping are sharing the same key(for example, if I bind "A" keys for controller 1 and controller 2 with of course "A" button. There will be 2 possible outcome

  • One controller have the "A" key and the other controller don't
    -Skyline will both output the keys for both controllers as "KEYCODE_BUTTON_A"), this shouldn't happen because the "if one controller is using that key then other controller can't use that" or "one is pressing, other controller isn't pressing but Skyline will recognise that that "non-pressing" controller is pressing the same key as that one controller that is pressing that key"(like 2 controllers is pressing that same A key but it's not)situation will happen if that problem persists

My guess for this problem is Skyline is thinking that there's only one controller that's connecting the the emulator, and that's why it only binds the same key for 2 controllers

@TheASVigilante TheASVigilante added the bug Something isn't working label Oct 25, 2023
@Crytonics
Copy link
Contributor

So if you map A key to 1 controller it will be autp mapped also for 2?

@Intelparcel
Copy link
Author

Intelparcel commented Oct 25, 2023

So if you map A key to 1 controller it will be autp mapped also for 2?

Very sorry if I'm confusing you, since English is my second language I'll try to describing this more clearly
What I meant is if I map button A as A key for controller 1 and then map button A from the second controller(kinda like map controller 1 and then controller 2, both are connecting to the phone)as A key then one of two situations will happen:
Picsart_23-10-25_20-23-54-368
Picsart_23-10-25_20-24-54-897
-One of the controller will lost the A key
Or:
Picsart_23-10-25_20-23-54-368
Picsart_23-10-25_20-24-30-117
Both controllers will have the same A key(Duplication issue like I'm describing in the above comment)

@Crytonics Crytonics added the question Further information is requested label Dec 22, 2023
@lynxnb
Copy link
Member

lynxnb commented Jan 4, 2024

Is this an issue in the UI only, or does it affect gameplay? We should already support multiple controllers, the fact that it's displayed as KEYCODE_BUTTON_A does not affect functionality and is completely fine.

@Intelparcel
Copy link
Author

Intelparcel commented Jan 4, 2024

Is this an issue in the UI only, or does it affect gameplay? We should already support multiple controllers, the fact that it's displayed as KEYCODE_BUTTON_A does not affect functionality and is completely fine.

I'm pretty sure both UI and gameplay
I've already described the issue in the above comment

@lynxnb
Copy link
Member

lynxnb commented Jan 4, 2024

I'm pretty sure both UI and gameplay

Have you run actual tests or are you going by assumptions? Does pressing A on two different controllers perform the same action in the game?
e.g. does pressing A on controller 2 perform the action for in-game character 1?

@Intelparcel
Copy link
Author

I'm pretty sure both UI and gameplay

Have you run actual tests or are you going by assumptions? Does pressing A on two different controllers perform the same action in the game? e.g. does pressing A on controller 2 perform the action for in-game character 1?

I've done actual tests(well most games I'm playing on skyline have this issue, "Cuphead" is the best one to notice)
If both controllers(1,2) pressing A, then one of the controller:

  • Unable to use(block) A key until other controller release the key
  • Will trigger random button, sometimes doing inversed action(rarely occurs)

@lynxnb lynxnb added good first issue Good for newcomers and removed question Further information is requested labels Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants