New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.24.0] Multiple health checks after one action (save/delete) #20216
Comments
The server restarts when you make changes to your content structure, the health checks are there by design to know when the client can reconnect and work again. |
Okay, I understand, but why so many calls for one action? I was expecting one health check for one action (to check if the server is running and is healthy), but seeing all the same health checks at the same period of time doesn't really make sense. It will impact the performance by doing all those calls. |
If the server restarts and you make one call it'll fail, how do you propose we then find out it it's restarted? |
Before doing any When doing the health check, we check if there's already a failed request. If so, we try to process the failed request and we repeat this process within a maximum amount of tries. (can be configured in the settings) before starting a new request. I don't know if there's already a retry mechanism for that feature. If the check is valid, we can continue normally on the app and remove pending requests. If the check is still invalid and we reach the maximum of tries, we can fallback to the ErrorFlow. It could be showing an error to the user and he might need to redo his actions, etc. |
How do you plan to keep the pending requests in the DB if the server is restarting and therefore unable to take any request? Sorry I might have misunderstood your proposal. |
I don't know how you can do it, but something with a try mechanism/backoff transaction, notification system, etc Here's the problem with a cloud infrastructure, not a local app. The app is deployed in the cloud and using a MySQL database. You can see the 2024-04-29_09-07-25.mp4If there's no way for a quick fix, can we disable temporary the health check using a configuration or something? I didn't find anything in the doc regarding that. Thanks! PS I also tested the strapi-beta5 as well and it does the same thing |
You are using development mode in a deployed environment which we do not support. You should even be able to modify the schema while it's deployed. Closing this as won't fix since it wouldn't be a problem locally and that's the only place you should be using the content-type builder. |
Bug report
Required System information
Describe the bug
When saving or deleting a component or a collection, multiples
/_health
checks are done after each action. On localhost it's 'fine', but in the cloud, resources are limited causing the server to be refreshed at a longer time and causing the server to crash, sometimes.Steps to reproduce the behavior
yarn create strapi-app my-strapi-project --typescript
Content-type Builder
Actual behavior
Multiple
/_health
checks are done in the Network tab and some of them are failing.Expected behavior
At least one
/health
check should be done, not multiple ones.Screenshots
Notice also that after the delete, I needed to refresh the page to see that the component is deleted.
Code snippets
Not applicable
Additional context
health
check is also there in other places like building a new collection.Question
Is it possible to turn off the
/_health
checks when doing an action in Strapi?The text was updated successfully, but these errors were encountered: