Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Popover does not close with the same button #1700

Open
MikhailTyuftyaev opened this issue Apr 23, 2024 · 0 comments
Open

[bug]: Popover does not close with the same button #1700

MikhailTyuftyaev opened this issue Apr 23, 2024 · 0 comments
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Milestone

Comments

@MikhailTyuftyaev
Copy link

What version of strapi-design-system are you using?

Npm version: 8.15.1
Node.js version: 20.11.1
Strapi Design System version: 1.14.1
Browser: Chrome

What's Wrong?

When you open a pop-up window with a button, it does not close on the second click (as it should be). I think this is due to the fact that both events are triggered: OnClick on the button, and onDismiss on the Popover. They change each other's states.

As you can see in this video, this bug is in Storybook Strapi. Also, when creating my plugin, I got the same error.

bandicam.2024-04-23.21-54-25-523.mp4

To Reproduce

This bug you can find the error in Storybook Strapi.

Expected Behaviour

Each time the button is clicked, the Popover must either open or close.

@MikhailTyuftyaev MikhailTyuftyaev added the issue: bug Issue reporting a bug label Apr 23, 2024
@joshuaellis joshuaellis added status: pending reproduction Waiting for free time to reproduce the issue, or more information source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Projects
None yet
Development

No branches or pull requests

2 participants