Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Link v2 has no hover color/effect #1525

Open
t-fritsch opened this issue Dec 18, 2023 · 6 comments
Open

[bug]: Link v2 has no hover color/effect #1525

t-fritsch opened this issue Dec 18, 2023 · 6 comments
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Milestone

Comments

@t-fritsch
Copy link

What version of strapi-design-system are you using?

strapi 4.15.5

What's Wrong?

Link v2 doesn't show the hover color on rollover

To Reproduce

go to https://design-system-git-main-strapijs.vercel.app/?path=/docs/design-system-components-v2-link--docs
rollover any link, style doesn't get updated on hover

Expected Behaviour

The hover color defined here should be shown on rollover :

&:hover {
color: ${({ theme }) => theme.colors.primary500};
}

It doesn't show up because it is overridden by the <Typography> component inside :

<Typography textColor={disabled ? 'neutral600' : 'primary600'}>{children}</Typography>

In Link V1, the hover effect works because the Typography component uses the currentColor CSS value :

${Typography} {
transition: color 150ms ease-out;
color: currentColor;
}

(Note anyway that putting a Typography component with no prop passing on it makes it impossible to fix this kind of bug on our side, and prevents also customizing the text, for adding ellipsis on it for example. I pray every day that styled component in strapi gets dropped in favor of real css 😂 ...)

@t-fritsch t-fritsch added the issue: bug Issue reporting a bug label Dec 18, 2023
@joshuaellis

This comment was marked as off-topic.

@t-fritsch

This comment was marked as off-topic.

@joshuaellis

This comment was marked as off-topic.

@t-fritsch

This comment was marked as off-topic.

@joshuaellis

This comment was marked as off-topic.

@t-fritsch

This comment was marked as off-topic.

@joshuaellis joshuaellis added status: confirmed Confirmed by a Strapi Team member or multiple community members source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Development

No branches or pull requests

2 participants