Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the issue of Tooltip position offset when there is no scroll bar on the page #1421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BlueBaidu
Copy link

What does it do?

Fixed an issue where the position of the tooltip shifted when the hover was first placed on the icon without a scroll bar on the page.

Adjusted the CSS style to ensure that the tooltip performs consistently on the first hover and subsequent hovers.

Why is it needed?

The previous issue resulted in poor user experience, as the offset of the tooltip position when the hover is first placed on the icon can cause confusion.

This modification fixes this issue and improves the usability of the user interface.

How to test it?

Open the application on a page without a scroll bar, Please refer to the demo document address:

https://api-0khig.strapidemo.com/admin/plugins/content-type-builder/content-types/api::place.place

Try hovering on the icon for the first time and observe if the position of the tooltip is correct.

Hover again on the icon and check if there is no positional offset.

Related issue(s)/PR(s)

Fixed: #1420

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

⚠️ No Changeset found

Latest commit: 481a3ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 2:45am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 2:45am

@BlueBaidu BlueBaidu changed the title fix: 修复在页面没有滚动条时,Tooltip位置出现偏移的问题 fix: Fix the issue of Tooltip position offset when there is no scroll bar on the page Oct 19, 2023
@innerdvations innerdvations added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Mar 26, 2024
@innerdvations innerdvations removed the request for review from gu-stav March 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
Status: To be reviewed
Development

Successfully merging this pull request may close these issues.

[bug]: When there is no scroll bar on the page, the floating position of Tooltip will shift
4 participants