Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IconButton disabled property #1393

Closed
wants to merge 1 commit into from
Closed

fix: IconButton disabled property #1393

wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

What does it do?

  • Fixes issue where the IconButton does not apply disable prop on the button

Why is it needed?

  • Can cause unexpected behavior

How to test it?

  1. Run the app yarn develop
  2. Find IconButton and click on Disabled
  3. Check if disable property is applied to the button

Demo

Screen.Recording.2023-09-19.at.13.50.42.57.mov

@gitstart @Mjanuary
fix: Resolves disabled prop is inconsistent across Button and IconButton
bf18c8c 
Co-authored-by: Mjanuary <22890925+Mjanuary@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: bf18c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 5:08pm
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 5:08pm

@joshuaellis joshuaellis closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gu-stav gu-stav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: disabled prop is inconsistent across Button and IconButton
3 participants
@gitstart @gu-stav @joshuaellis