Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: disabled prop is inconsistent across Button and IconButton #1345

Open
gu-stav opened this issue Sep 12, 2023 · 0 comments
Open

[bug]: disabled prop is inconsistent across Button and IconButton #1345

gu-stav opened this issue Sep 12, 2023 · 0 comments
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Milestone
v2.0.0

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Sep 12, 2023

What version of strapi-design-system are you using?

  • DS: 1.10.1

What's Wrong?

The disabled property leads to inconsistent markup between Button and IconButton. For button the disabled HTML attribute is set, where as for IconButton aria-disabled is set only.

To Reproduce

Button: https://design-system-git-main-strapijs.vercel.app/?path=/story/design-system-components-button--disabled
IconButton: https://design-system-git-main-strapijs.vercel.app/?path=/story/design-system-components-iconbutton--disabled

Expected Behaviour

We should unify the behavior:

  • set the disabled attribute
  • remove aria-disabled because it is duplicated information and probably not necessary
@gu-stav gu-stav added the issue: bug Issue reporting a bug label Sep 12, 2023
@gitstart gitstart mentioned this issue Oct 10, 2023
Closed
@joshuaellis joshuaellis added status: confirmed Confirmed by a Strapi Team member or multiple community members source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix: IconButton disabled property gitstart/strapi-design-system
2 participants
@gu-stav @joshuaellis