Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Consistent loading state for Select and Combobox #1331

Open
gu-stav opened this issue Sep 6, 2023 · 0 comments
Open

[feat]: Consistent loading state for Select and Combobox #1331

gu-stav opened this issue Sep 6, 2023 · 0 comments
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Sep 6, 2023

A clear and concise description of what the feature is

Add a isLoading property to Select and Combobox components, to render a spinner.

Why should this feature be included?

In the CMS we have to load a lot of data when rendering, which leads to loading spinners. The Select and Combobox components are not exceptions and often depend on data being loaded (e.g. for review workflows).

While it is possible to set a loading state for Select via customizeContent it is not for Combobox, and therefore when used together both components appear different during the loading phase.

Please provide an example for how this would work

see above

@gu-stav gu-stav added the issue: enhancement Issue suggesting an enhancement to an existing feature label Sep 6, 2023
@joshuaellis joshuaellis added the source: design-system relates to design-system package label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package
Projects
None yet
Development

No branches or pull requests

2 participants