Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disabled focus state of Select and Combobox is inconsistent #1343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Disabled focus state of Select and Combobox is inconsistent #1343

wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

What does it do?

  • Fixes issue of the disabled Combobox display focused state.

Why is it needed?

  • The focus state of a disabled Select and Combobox is inconsistent.

How to test it?

  1. Run the app yarn develop
  2. Find Combobox in Components and click show the disabled state button.
  3. See that the Combobox doesn't display the primary outline.

Demo

https://www.loom.com/share/e8c19a7cccd84270ba65a8a27a2345b4

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @AqidaHaidari
fix: Resolves the inconsistency of the disabled focus state of the Se…
bff7726 
…lect and Combobox

Co-authored-by: AqidaHaidari <42426077+AqidaHaidari@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

⚠️ No Changeset found

Latest commit: bff7726

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ❌ Failed (Inspect) Sep 12, 2023 7:22am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 7:22am

@gitstart gitstart changed the title SDS-158 - [bug]: Disabled focus state of Select and Combobox is inconsistent fix: Disabled focus state of Select and Combobox is inconsistent Sep 12, 2023
@gitstart gitstart marked this pull request as ready for review September 12, 2023 07:47
@joshuaellis joshuaellis self-requested a review October 2, 2023 08:32
@joshuaellis joshuaellis self-assigned this Oct 2, 2023
@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis Awaiting requested review from joshuaellis

At least 1 approving review is required to merge this pull request.

Assignees

@joshuaellis joshuaellis

Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Disabled focus state of Select and Combobox is inconsistent
2 participants
@gitstart @joshuaellis