Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Disabled focus state of Select and Combobox is inconsistent #1330

Open
gu-stav opened this issue Sep 6, 2023 · 1 comment · May be fixed by #1343
Open

[bug]: Disabled focus state of Select and Combobox is inconsistent #1330

gu-stav opened this issue Sep 6, 2023 · 1 comment · May be fixed by #1343
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Milestone
v2.0.0

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Sep 6, 2023

What version of strapi-design-system are you using?

  • Design-System: 1.10.0

What's Wrong?

The focus state of a disabled Select and Combobox is inconsistent. While Select does not display the focus outline (which imo is the proper behavior) the Combobox does:

Kapture.2023-09-06.at.08.44.47.mp4

To Reproduce

  1. Use Select and Combobox next to each other
  2. Add disabled=true to both
  3. Focus both fields

Expected Behaviour

I expect Combobox to not receive any events nor display a visible focus state. It could also be discussed which cursor to display in this case, because it is inconsistent too.
@gu-stav gu-stav added the issue: bug Issue reporting a bug label Sep 6, 2023
@Parathantl
Copy link

Hi @gu-stav,
I am new to the Strapi contribution. Would it possible for me to take this? If you could give me guidance It would be grateful

@gitstart gitstart linked a pull request Sep 12, 2023 that will close this issue
Open
@joshuaellis joshuaellis added status: confirmed Confirmed by a Strapi Team member or multiple community members source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix: Disabled focus state of Select and Combobox is inconsistent gitstart/strapi-design-system
3 participants
@gu-stav @Parathantl @joshuaellis