Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: RTL support #1308

Open
Bokitza opened this issue Aug 26, 2023 · 0 comments · Fixed by #1685
Open

[feat]: RTL support #1308

Bokitza opened this issue Aug 26, 2023 · 0 comments · Fixed by #1685
Assignees
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature
Milestone

Comments

@Bokitza
Copy link

Bokitza commented Aug 26, 2023

A clear and concise description of what the feature is

A design refactor that will support a RTL display of strapi admin (navbar-right, main content-left) - for Arabic, hebrew, etc...

Why should this feature be included?

Currently, Strapi design system uses a padding-{side} attribute to space contents between logos, texts and sections.

e.g:

Screenshot 2023-08-27 at 0 05 54 image

If I for instance want to use strapi in a RTL direction, for it to support Arabic|Hebrew native view direction, it will look like this (emulating by writing in the console document.body.dir="rtl") :

image

You can see that the padding-right attribute is not supporting the flow of the document, and in general, it is a bad practice for spacing stuff, especially in a Flex Gap era 😄

Please provide an example for how this would work

I recommend moving to a Gap-based row gaps instead of (ab)using padding.

as i can emulate in the chrome devtools:

image

i give every row a gap: 12px
I disable the padding-right:12px (notice for the example I disabled only 'content manager' and 'content-type builder'

here's how it is in the classic ltr:
image

(again, changed just the padding only for the first 2 buttons in the sidebar)

@Bokitza Bokitza added the issue: enhancement Issue suggesting an enhancement to an existing feature label Aug 26, 2023
@joshuaellis joshuaellis linked a pull request May 7, 2024 that will close this issue
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants