Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Combobox returning NULL if no option is available #1185

Open
noobCode-69 opened this issue Jul 10, 2023 · 1 comment
Open

[bug]: Combobox returning NULL if no option is available #1185

noobCode-69 opened this issue Jul 10, 2023 · 1 comment
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Milestone
v2.0.0

Comments

@noobCode-69
Copy link

What version of strapi-design-system are you using?

  • Npm version : Not applicable
  • Node version : Not applicable
  • Browser : Every browser

What's Wrong?

If you don't have any options for Combobox there is nothing in the screen to show that.

To Reproduce

  • Go to the Combobox storybook file
  • Remove Combobox options
  • Go to localhost
  • open Combobox story

Expected Behaviour

I expect a placeholder message that reads "Nothing available"
@noobCode-69 noobCode-69 added the issue: bug Issue reporting a bug label Jul 10, 2023
@noobCode-69
Copy link
Author

I think the same bug , is causing issue "CM: Relations no longer display "No relations available" when target CT is empty #17231" in the strapi repo

@noobCode-69 noobCode-69 changed the title [bug]: Combobox returning NULL if not option is given [bug]: Combobox returning NULL if no option is available Jul 10, 2023
noobCode-69 added a commit to noobCode-69/design-system that referenced this issue Jul 10, 2023
@noobCode-69
fixed:[bug]: Combobox returning NULL if not option is given strapi#1185
f2a77ef
@noobCode-69 noobCode-69 mentioned this issue Jul 10, 2023
Closed
noobCode-69 added a commit to noobCode-69/design-system that referenced this issue Jul 11, 2023
@noobCode-69
fixed:[bug]: Combobox returning NULL if not option is given strapi#1185
fabae11
@joshuaellis joshuaellis added status: confirmed Confirmed by a Strapi Team member or multiple community members source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@joshuaellis @noobCode-69