Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Dialog closes the Modal component #1154

Open
marco-villanueva opened this issue Jun 22, 2023 · 0 comments
Open

[bug]: Dialog closes the Modal component #1154

marco-villanueva opened this issue Jun 22, 2023 · 0 comments
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Milestone

Comments

@marco-villanueva
Copy link

What version of strapi-design-system are you using?

npm: 8.3.0.
node: 16.17.0
Strapi: 4.11.2
Design-system: 1.8.0

What's Wrong?

When I have a modal open, and this modal is going to open a confirmation window (Dialog component), any click on a button or not, closes the modal component.

It seems to me that the DismissableLayer is causing conflicts between Modal, Dialog and PopOver.

To Reproduce

  1. Insert a modal
  2. That the modal has a button or an actionable that raises a Dialog,
  3. Click on the dialog body
  4. Observe how the modal that was behind closes.

Expected Behaviour

To be able to interact with the dialog without affecting the layers behind it such as the modal.

@marco-villanueva marco-villanueva added the issue: bug Issue reporting a bug label Jun 22, 2023
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
@joshuaellis joshuaellis added status: pending reproduction Waiting for free time to reproduce the issue, or more information source: design-system relates to design-system package labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: design-system relates to design-system package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Projects
None yet
Development

No branches or pull requests

2 participants