Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: IdentityFileEntry.into_identity and .to_recipient not accessible #380

Open
bspot opened this issue Apr 18, 2023 · 2 comments
Open

API: IdentityFileEntry.into_identity and .to_recipient not accessible #380

bspot opened this issue Apr 18, 2023 · 2 comments
Milestone

Comments

@bspot
Copy link

bspot commented Apr 18, 2023

I appears that IdentityFileEntry.into_identity and .to_recipient are pub(crate), so I can't use them in my own crate.

pub(crate) fn into_identity(

Is there a specific reason for that or could they be made pub?

@str4d
Copy link
Owner

str4d commented Aug 7, 2023

The logic they implement can be implemented outside the age crate, because IdentityFileEntry is a transparent enum. That being said, they are nice helpers to have available. The only issue is that if the plugin feature is not enabled, it would be preferable to not require the callbacks argument, which makes the API a bit awkward to use, but that is still doable.

@str4d str4d added this to the rage 0.10.0 milestone Aug 7, 2023
@str4d
Copy link
Owner

str4d commented Aug 7, 2023

Hmm, this might end up interacting with the refactor I need to do as mentioned in #334 (comment). So while I can place the callbacks arg behind the plugin feature flag, I'll wait until I'm a bit further into #403 before working on this issue.

@str4d str4d modified the milestones: rage 0.10.0, rage 0.11.0 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants