Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoMiniSat build script needs updating #481

Open
gussmith23 opened this issue Apr 16, 2024 · 5 comments · May be fixed by #482
Open

CryptoMiniSat build script needs updating #481

gussmith23 opened this issue Apr 16, 2024 · 5 comments · May be fixed by #482

Comments

@gussmith23
Copy link

gussmith23 commented Apr 16, 2024

CMS has added new dependencies. Their README now has the following installation script:

sudo apt-get install build-essential cmake

# not required but very useful
sudo apt-get install zlib1g-dev

git clone https://github.com/meelgroup/cadical
cd cadical
git checkout mate-only-libraries-1.8.0
./configure
make
cd ..

git clone https://github.com/meelgroup/cadiback
cd cadiback
git checkout mate
./configure
make
cd ..

tar xzvf cryptominisat-version.tar.gz
cd cryptominisat-version
mkdir build && cd build
cmake ..
make
sudo make install
sudo ldconfig

Specifically, it seems like the CadiBack dependency is missing.

Seems like there's two ways to fix:

Either way, should be a quick fix!

@aytey
Copy link
Member

aytey commented Apr 16, 2024

Thanks for the report; we'll take a look.

@msoos: is CaDiCaL now a required dependency for CMS? I'm just surprised that to build a SAT solver it seems you now need another SAT solver.

@msoos
Copy link
Member

msoos commented Apr 16, 2024

Hi,

Yeah, sorry. I didn't now where to integrate cadiback. I didn't want to reimplement cadiback... so yeah. Also, I wanted to give credit, where credit is due -- CadiBack. This is for Arjun, the preprocessor that we have built. It's an insanely high-performance CNF preprocessor for model counting and also SAT solving. Unfortunately, it requires backbone detection. I have built one, and it's OK, but it's not like CadiBack. To be clear, I could improve CadiBack, if I had time, and I will improve it, but... not now. Don't know what to do. Sorry.

Mate

@aytey
Copy link
Member

aytey commented Apr 16, 2024

and I will improve it, but... not now. Don't know what to do. Sorry.

No stress :)

We can update the docs/scripts for STP to pull down those deps.

@msoos
Copy link
Member

msoos commented Apr 16, 2024

Thanks so much! 😻

@gussmith23
Copy link
Author

Thanks all for the quick response on this!

@gussmith23 gussmith23 linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants